Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align log with execution apis #337

Closed
rafaelkallis opened this issue Jul 14, 2022 · 1 comment · Fixed by #343
Closed

Align log with execution apis #337

rafaelkallis opened this issue Jul 14, 2022 · 1 comment · Fixed by #343
Assignees
@natanasow
Labels
bug Something isn't working limechain P1
Projects
Development
Milestone
0.5.0

Comments

@rafaelkallis
Copy link
Contributor

Description

hedera-json-rpc-relay/packages/relay/src/lib/eth.ts

Lines 825 to 835 in 73d8244

return new Log({
address: log.address,
blockHash: EthImpl.toHash32(receiptResponse.block_hash),
blockNumber: receiptResponse.block_number,
data: log.data,
logIndex: log.index,
removed: false,
topics: log.topics,
transactionHash: EthImpl.toHash32(receiptResponse.hash),
transactionIndex: receiptResponse.transaction_index
});

blockNumber, transactionIndex, logIndex require EthImpl.numberTo0x because they are of type uint (execution-api reference https://github.com/ethereum/execution-apis/blob/8e43f278b8afdf2f496383361275a515d87b80cf/src/schemas/receipt.yaml#L10-L24)

Steps to reproduce

Fetch any transaction receipt with logs, e.g. transaction 0x9040d4244cfeb7c5fc96ac378308d9df8a6616c550e9d02162b3ef3fe889df86

Additional context

Transaction receipt response, compare result.blockNumber and result.logs[*].blockNumber , one of them must be wrong :)

image

Hedera network

testnet

Version

0.3.0

Operating system

Linux
@rafaelkallis rafaelkallis added the bug Something isn't working label Jul 14, 2022
@Nana-EC
Copy link
Collaborator

Nana-EC commented Jul 19, 2022

Correct. We should be hex encoding all uints according the schema

@Nana-EC Nana-EC added this to the 0.5.0 milestone Jul 19, 2022
@Nana-EC Nana-EC added the P1 label Jul 19, 2022
@Nana-EC Nana-EC added this to Sprint Commitment in Development Jul 19, 2022
@natanasow natanasow self-assigned this Jul 19, 2022
@natanasow natanasow mentioned this issue Jul 19, 2022
Merged
2 tasks
@natanasow natanasow moved this from Sprint Commitment to In progress in Development Jul 19, 2022
@natanasow natanasow moved this from In progress to For Review in Development Jul 19, 2022
Development automation moved this from For Review to Done Jul 20, 2022
@Nana-EC Nana-EC mentioned this issue Jul 21, 2022
Merged
2 tasks
Nana-EC added a commit that referenced this issue Jul 21, 2022
@Nana-EC @natanasow
Align log with execution apis (0.4) (#364)
10c6823 
CHerry-pick #337 to release/0.4

Update log response integers to be hexadecimals

Signed-off-by: Nikolay Atanasow <[email protected]>
Signed-off-by: Nana-EC <[email protected]>

Co-authored-by: Nikolay Atanasow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natanasow natanasow

Labels
bug Something isn't working limechain P1
Projects
Development
Done
Smart Contract Sprint Board
Archived in project
Milestone
0.5.0
Development

Successfully merging a pull request may close this issue.

Align log with execution apis hashgraph/hedera-json-rpc-relay
3 participants
@rafaelkallis @natanasow @Nana-EC