Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align log with execution apis (0.4) #364

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jul 21, 2022

Description:
CHerry-pick #337 to release/0.4

Update log response integers to be hexadecimals

Related issue(s):

Fixes #337

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC self-assigned this Jul 21, 2022
@Nana-EC Nana-EC added bug Something isn't working P1 labels Jul 21, 2022
@Nana-EC Nana-EC added this to In progress in Development via automation Jul 21, 2022
@Nana-EC Nana-EC modified the milestones: 0.5.0, 0.4.0 Jul 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2022

Codecov Report

Merging #364 (2a733d9) into release/0.4 (37d5eb6) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/0.4     #364   +/-   ##
============================================
  Coverage        62.29%   62.29%           
============================================
  Files                9        9           
  Lines              870      870           
  Branches           142      142           
============================================
  Hits               542      542           
  Misses             290      290           
  Partials            38       38           
Impacted Files Coverage Δ
packages/relay/src/lib/eth.ts 64.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d5eb6...2a733d9. Read the comment docs.

Update log response integers to be hexadecimals

Signed-off-by: Nikolay Atanasow <[email protected]>
Signed-off-by: Nana-EC <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@ar-conmit ar-conmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC merged commit 10c6823 into release/0.4 Jul 21, 2022
Development automation moved this from In progress to Done Jul 21, 2022
@Nana-EC Nana-EC deleted the 337-port-to-0-4-0 branch July 21, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants