Support 'from' in 'eth_call' #375
Conversation
When a from value is in the eth_call params, set it to the senderId. Signed-off-by: Danno Ferrin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #375 +/- ##
==========================================
+ Coverage 62.21% 62.98% +0.77%
==========================================
Files 9 9
Lines 868 870 +2
Branches 142 143 +1
==========================================
+ Hits 540 548 +8
+ Misses 290 282 -8
- Partials 38 40 +2
Continue to review full report at Codecov.
|
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
| } | ||
| ); | ||
|
|
||
| const result = await ethImpl.call({ |
There was a problem hiding this comment.
For completeness of coverage this methods should be checking that the result is expected.
Given the return above i think the expected result would be 0x0 or 0x.
Should make this change for the 4 tests added.
| const contract = new ethers.Contract(evmAddress, abi, accounts[0].wallet); | ||
|
|
||
| return contract; | ||
| return new ethers.Contract(evmAddress, abi, accounts[0].wallet); | ||
| }; | ||
| }); |
There was a problem hiding this comment.
nit: new line since you're here.
There was a problem hiding this comment.
LGTM! We might want to resolve @Nana-EC 's comments and then merge :)
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
* Support from in eth_call When a from value is in the eth_call params, set it to the senderId. Signed-off-by: Danno Ferrin <[email protected]>
Cherry pick #375 When a from value is in the eth_call params, set it to the senderId. Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]>
Description:
When a from value is in the eth_call params, set it to the senderId.
Related issue(s):
Fixes #373
Notes for reviewer:
Checklist