Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'from' in 'eth_call' (0.4) #383

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Jul 25, 2022

Description:
Cherry pick #375

When a from value is in the eth_call params, set it to the senderId.

Related issue(s):

Fixes #373

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Support from in eth_call

When a from value is in the eth_call params, set it to the senderId.

Signed-off-by: Danno Ferrin <[email protected]>
@Nana-EC Nana-EC requested a review from shemnon July 25, 2022 22:49
@Nana-EC Nana-EC self-assigned this Jul 25, 2022
@Nana-EC Nana-EC added bug Something isn't working P1 labels Jul 25, 2022
@Nana-EC Nana-EC added this to In progress in Development via automation Jul 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC modified the milestones: 0.4.0, 0.4.1 Jul 25, 2022
@Nana-EC Nana-EC requested a review from lukelee-sl July 25, 2022 22:54
@Nana-EC Nana-EC merged commit e7774ea into release/0.4 Jul 26, 2022
Development automation moved this from In progress to Done Jul 26, 2022
@Nana-EC Nana-EC deleted the 373-eth-call-sender-pick-0-4 branch July 26, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants