Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorConfig & Rebracer settings #501

Merged
merged 1 commit into from
Nov 13, 2014

Conversation

SLaks
Copy link
Contributor

@SLaks SLaks commented Nov 9, 2014

This ensures that contributors will match the formatting of the existing code.

@sharwell
Copy link
Contributor

This is the perfect case to just add a reference to VSSDK.Shell.10. Why include it in the repository?

@sharwell
Copy link
Contributor

Yikes, I was expecting packages/ to be excluded from source control.

@SLaks SLaks changed the title Fix compilation issues Fix addin & compilation issues Nov 12, 2014
The current code is inconsistent in many places;
these settings seem to be the closest match.

https://visualstudiogallery.msdn.microsoft.com/410e9b9f-65f3-4495-b68e-15567e543c58
http://editorconfig.org/
@SLaks SLaks changed the title Fix addin & compilation issues Add EditorConfig & Rebracer settings Nov 13, 2014
@sharwell
Copy link
Contributor

The .editorconfig file and extension have proven very reliable in my experience. The @ilspy team can verify whether the settings match what they expect.

I haven't used Rebracer. The team will also need to verify those settings.

siegfriedpammer added a commit that referenced this pull request Nov 13, 2014
Add EditorConfig & Rebracer settings
@siegfriedpammer siegfriedpammer merged commit 4e44dc9 into icsharpcode:master Nov 13, 2014
@SLaks SLaks deleted the cleanup branch November 14, 2014 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants