Do not merge yet: Fix decompiler to work with Roslyn-compiled code #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roslyn doesn't look at inherited true/false operators. https://roslyn.codeplex.com/workitem/358
Includes failing test case
The current code is inconsistent in many places; this seems to be the closest match.
This contains no functional changes, except that it will ignore blank lines when comparing code. This reduces duplicate code, and will make it easier to add assertions for Roslyn compilers
Still requires the appropriate SDK to be installed. Thanks @sharwell for much simpler implementation
As long as we reference all VS assemblies from this package and make sure to stick to v10 packages, the addin should work in every version of Visual Studio starting with 2010.
This is why it's important to use extensions like EditorConfig & Rebracer; it lets us avoid these inconsistent messes.
explorer.SelectedItems returns object[]
Otherwise, ILSpy will fail to start if it isn't already running. This bloats the VSIX to nearly 6MB, but there is no alternative.
The addin will now work on VS2010 without installing .Net 4.5.
Not yet used
This introduces lots of test failures which will hopefully be fixed later. See icsharpcode#502
Roslyn fully inlines the temporary TypedReference variable
These fields are already initialized to default(S). Roslyn completely drops the duplicate initialization.
This makes it much easier to spot regressions from the legacy compiler
SLaks
changed the title
|
Any update on this? |
|
No; I haven't had time to work on this for a while. |
|
Hmm, well, it doesn't seem like you should avoid fixing bugs just because it isn't clear how best to test for their recurrence. |
|
Sorry; I do not have time to work on this at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502
This is an ongoing pull request; I will keep pushing commits as I fix more issues.
You can merge this whenever you want; I'll make new pull requests as I make more fixes. (it would be better to merge more often)
The first 8 commits are from #501.
Can you please merge that before looking at this PR?
Once you do that, I'll rebase this so that it starts from upstream HEAD, without the duplicate commits.