isFlow robustness, common code into (new) FlowUtil #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyasoifer
reviewed
Jan 23, 2024
| public static final String TAG_T0 = "t0"; | ||
| public static final double MIN_PROB_DEFAULT = 0.01; | ||
| public static String ATTR_TP = "tp"; | ||
| public static String ATTR_TI = "ti"; |
There was a problem hiding this comment.
@dror27 - can we get rid of ATTR_TI please? Only very old data used that tag
|
Fixes #1468 |
|
@ilyasoifer references to TI removed. Please note that this change is limited to the isFlow issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.