You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IAmNotHanni
changed the title
Do not pass data to constructors which is already contained in wrapper::Device
Do not pass data which is already contained in wrapper::Device
Sep 5, 2020
Don't pass redundant data
Instead of doing this:
m_imgui_overlay = std::make_unique<imgui::ImGUIOverlay>(*m_vkdevice, *m_swapchain, m_vkdevice->physical_device(), m_vkdevice->allocator(), m_vkdevice->graphics_queue(), m_vkdevice->graphics_queue_family_index());
Do this:
Because the other data is already available through
m_vkdevice
.Rethink use of queues
The text was updated successfully, but these errors were encountered: