Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pass data which is already contained in wrapper::Device #238

Closed
IAmNotHanni opened this issue Sep 5, 2020 · 0 comments · Fixed by #245
Closed

Do not pass data which is already contained in wrapper::Device #238

IAmNotHanni opened this issue Sep 5, 2020 · 0 comments · Fixed by #245
Assignees
Labels
cat:refactor refactor/clean up/simplifications/etc.

Comments

@IAmNotHanni
Copy link
Member

Don't pass redundant data

Instead of doing this:

m_imgui_overlay = std::make_unique<imgui::ImGUIOverlay>(*m_vkdevice, *m_swapchain,
 m_vkdevice->physical_device(),
 m_vkdevice->allocator(), m_vkdevice->graphics_queue(),
 m_vkdevice->graphics_queue_family_index());

Do this:

m_imgui_overlay = std::make_unique<imgui::ImGUIOverlay>(*m_vkdevice, *m_swapchain);

Because the other data is already available through m_vkdevice .

Rethink use of queues

  • Currently we're using graphics queue even in cases where transfer queue would be appropriate!
@IAmNotHanni IAmNotHanni added the cat:refactor refactor/clean up/simplifications/etc. label Sep 5, 2020
@IAmNotHanni IAmNotHanni self-assigned this Sep 5, 2020
@IAmNotHanni IAmNotHanni changed the title Do not pass data to constructors which is already contained in wrapper::Device Do not pass data which is already contained in wrapper::Device Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:refactor refactor/clean up/simplifications/etc.
Projects
None yet
1 participant