[renderer] Remove redundant arguments which are available through device wrapper. #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #238
This pull requests takes the essential work from my overloaded draft pr #241.
In this pull request, I removed redundant arguments which are already available through the device wrapper's get methods.
This code change also fixes an issues with queue management. The problem is that sometimes we passed the graphics queue to a constructor which names it internally as
data_transfer_queue
. Because both are justVkQueue
, the constructor accepts it and passes it on even further down to the members.For example this:
m_textures.emplace_back(*m_vkdevice, m_vkdevice->physical_device(), m_vkdevice->allocator(), texture_file, texture_name, m_vkdevice->graphics_queue(), m_vkdevice->graphics_queue_family_index());
will be passed on to:
This new code has been changed so it is the constructor call to
CommandBuffer
which specifies the queue which is used.EDIT: I forgot to mention I also forward-declared most variables in the RAII wrapper header files.