-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[renderer] Small refactorings #241
Conversation
…wrapper Signed-off-by: Johannes <[email protected]>
This code change also fixes an issues with queue management. The problem is that sometimes we passed the graphics queue to a constructor which names it internally as For example this: m_textures.emplace_back(*m_vkdevice, m_vkdevice->physical_device(),
m_vkdevice->allocator(), texture_file,
texture_name, m_vkdevice->graphics_queue(),
m_vkdevice->graphics_queue_family_index()); will be passed on to: Texture::Texture(const wrapper::Device &device, const VkPhysicalDevice graphics_card,
const VmaAllocator vma_allocator, const std::string &file_name,
const std::string &name, const VkQueue data_transfer_queue,
const std::uint32_t data_transfer_queue_family_index) This new code has been changed so it is the constructor call to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :)
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
Signed-off-by: Johannes <[email protected]>
I will include other small refactorings into this pull request as well. |
void load_toml_configuration_file(const std::string &file_name); | ||
|
||
/// @brief | ||
VkResult load_textures(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not done yet here but I wanted to push just already. Will finish and squash later.
I changed my mind: I overloaded this pull request! |
Closes #238.