-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Fix cmake gui multi config generation #262
Conversation
8afd014
to
6466488
Compare
The dependencies will still not be passed to the Visual Studio project map file sadly. |
I think we can close this pull request for now: #372 |
Only admins can convert it back into a draft ^^ aka. you |
6466488
to
6b8f572
Compare
6b8f572
to
08a488b
Compare
Amazing! I think we need to boost the required minimum CMake version?
|
Delete your build folder. |
Now I get this error: CMake Error at build/conan.cmake:71 (message):
Please specify in command line CMAKE_BUILD_TYPE
(-DCMAKE_BUILD_TYPE=Release)
Call Stack (most recent call first):
build/conan.cmake:430 (_conan_detect_build_type)
cmake/conan_setup.cmake:35 (conan_cmake_autodetect)
CMakeLists.txt:34 (include) |
I know I could specify this now, but shouldn't be there a default setting for unexperienced programmers? |
8cd8238
to
a4dce85
Compare
Looks like some spdlog is configured in release mode, even though I want to compile inexor-vulkan-renderer-example as Debug:
Release build is working already though! |
a4dce85
to
3163d0f
Compare
We have to add |
4710a5a
to
8f82282
Compare
8f82282
to
c80084d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works now! Amazing job!
I think this one just needs a rebase now? |
Merge #368 first. |
1c00d3d
to
7bf9dd0
Compare
7bf9dd0
to
2c2e4ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work again. Looks like we finally defeated this problem.
Works in Debug
and Release
config under Ubuntu 20.04 if I use cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug/Release
.
All configurations build correctly when using Visual Studio 16 2019: Release
, MinSizeRel
, Debug
, and RelWithDebInfo
.
This is amazing!
2c2e4ce
to
202a505
Compare
Rebased. |
Can you confirm it fixes the issue and it is really build against the debug and release libraries.
Based on #368
Close #228
Close #372