Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iceflower/various #368

Merged
merged 6 commits into from
May 6, 2021
Merged

Iceflower/various #368

merged 6 commits into from
May 6, 2021

Conversation

IceflowRE
Copy link
Member

@IceflowRE IceflowRE commented Apr 22, 2021

Close #367

@IceflowRE IceflowRE added cat:dev tools building/ compiling the program, cmake configuration and general development tools feat:ci continuous integration cat:documentation documentation org:review changes are finished, review in progress or requested labels Apr 22, 2021
@IceflowRE IceflowRE requested review from movabo, IAmNotHanni and yeetari and removed request for movabo April 22, 2021 16:53
Copy link
Member

@IAmNotHanni IAmNotHanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work for me on Ubuntu (I updated to conan 1.35.2):

cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug
-- INEXOR_BUILD_BENCHMARKS = OFF
-- INEXOR_BUILD_DOC = OFF
-- INEXOR_BUILD_EXAMPLE = ON
-- INEXOR_BUILD_TESTS= OFF
-- INEXOR_CONAN_PROFILE = default
-- INEXOR_USE_VMA_RECORDING = OFF
-- CMAKE_VERSION = 3.16.3
-- CMAKE_GENERATOR = Ninja
-- C Compiler executable: /usr/bin/cc
-- CXX Compiler executable: /usr/bin/c++
-- Linker executable: /usr/bin/ld
-- Build type: Debug
-- Conan: checking conan executable
-- Conan: Found program /home/johannes/.local/bin/conan
-- Conan: Version found Conan version 1.35.2

CMake Error at cmake/conan_setup.cmake:30 (conan_cmake_autodetect):
  Unknown CMake command "conan_cmake_autodetect".
Call Stack (most recent call first):
  CMakeLists.txt:34 (include)

@movabo
Copy link
Collaborator

movabo commented Apr 22, 2021

Cannot test right now, will do it later. Reminder: you also wanted to rename *childs to *children. :)

@IceflowRE
Copy link
Member Author

Doesn't work for me on Ubuntu (I updated to conan 1.35.2):

cmake -Bbuild -GNinja -DCMAKE_BUILD_TYPE=Debug
-- INEXOR_BUILD_BENCHMARKS = OFF
-- INEXOR_BUILD_DOC = OFF
-- INEXOR_BUILD_EXAMPLE = ON
-- INEXOR_BUILD_TESTS= OFF
-- INEXOR_CONAN_PROFILE = default
-- INEXOR_USE_VMA_RECORDING = OFF
-- CMAKE_VERSION = 3.16.3
-- CMAKE_GENERATOR = Ninja
-- C Compiler executable: /usr/bin/cc
-- CXX Compiler executable: /usr/bin/c++
-- Linker executable: /usr/bin/ld
-- Build type: Debug
-- Conan: checking conan executable
-- Conan: Found program /home/johannes/.local/bin/conan
-- Conan: Version found Conan version 1.35.2

CMake Error at cmake/conan_setup.cmake:30 (conan_cmake_autodetect):
  Unknown CMake command "conan_cmake_autodetect".
Call Stack (most recent call first):
  CMakeLists.txt:34 (include)

Reset cmake cache?

@IAmNotHanni

This comment has been minimized.

@IAmNotHanni
Copy link
Member

I will try to get it working on Ubuntu as well.

@IceflowRE IceflowRE force-pushed the iceflower/various branch 2 times, most recently from e6d83fb to dd446f2 Compare April 23, 2021 09:09
@IceflowRE IceflowRE force-pushed the iceflower/various branch 4 times, most recently from 2614776 to 224ef51 Compare April 27, 2021 18:53
@IceflowRE IceflowRE closed this Apr 27, 2021
@IceflowRE IceflowRE reopened this Apr 27, 2021
@IAmNotHanni
Copy link
Member

IAmNotHanni commented Apr 29, 2021

Ok if I use cmake -B./cmake-build-debug/ -DCMAKE_BUILD_TYPE=Debug -G "Visual Studio 16 2019" -A x64 ./ it works on Windows. Since the CMake UI issue is not part of this pull request, we should ignore it. I will test on Ubuntu now.

@IAmNotHanni
Copy link
Member

IAmNotHanni commented Apr 29, 2021

Both Debug and Release works on Ubuntu 20.04 LTS when using cmake -GNinja -DCMAKE_BUILD_TYPE=Debug -Bbuild and
cmake -GNinja -DCMAKE_BUILD_TYPE=Release -Bbuild.

I build with cmake --build build --target inexor-vulkan-renderer-example.

@IceflowRE IceflowRE force-pushed the iceflower/various branch 3 times, most recently from f11ac66 to 6fda89a Compare April 30, 2021 11:43
@IAmNotHanni IAmNotHanni self-requested a review April 30, 2021 16:12
Copy link
Collaborator

@movabo movabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@IAmNotHanni
Copy link
Member

Do you want to squash before merge?

@IceflowRE
Copy link
Member Author

Do you want to squash before merge?

Actually i didn't intended to do so.

@IAmNotHanni
Copy link
Member

So let's finish the warning-cleanup first?

@IceflowRE
Copy link
Member Author

IceflowRE commented May 5, 2021

So let's finish the warning-cleanup first?

This PR is required for the warning cleanup due to the [*] category, which is introduced here.

Nevermind. :D Yeah go ahead.

@IAmNotHanni IAmNotHanni merged commit 62689a9 into master May 6, 2021
@IceflowRE IceflowRE deleted the iceflower/various branch June 25, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:dev tools building/ compiling the program, cmake configuration and general development tools cat:documentation documentation feat:ci continuous integration org:review changes are finished, review in progress or requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conan cmake run deprecated
3 participants