-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IT-1228: Refactor repo to use isxcore C++ API #54
base: main
Are you sure you want to change the base?
Conversation
i am curious to learn how users can install this on macos/arm64 outside of a conda environment |
@sg-s Unfortunately the isxcore c++ api is not compatible with arm64 on macos yet. This is another big revamp of the api that I want to prioritize for this year, but it's not in the scope of this PR. For the time being, users can use the previous, limited, pure python api version. Another option is creating a Docker image with the Linux version of the api installed so that users with Apple Silicon can use this api. Do you think that would be helpful? |
i see. a lot of my original motivation was just the ability to read isxd files on macOS/arm64. excited to see the new c++ api when it's compiled for arm64! |
What type of PR is this? (check all applicable)
Description
Refactor the python API so that it's no longer a pure python implementation. Instead this API is a wrapper around the
isxcore
C++ API, used in the IDPS GUI and IDPS Python/MATLAB APIs.Related Issues & Documents
Testing Instructions
Please replace this line with instructions on how to test your changes, a note
on the OS and python versions this has been tested on, as well as any relevant
images/screenshots.
Added/updated tests?
have not been included