Accessibility improvements #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a formal approach to fixing jackmoore#765 with proper use of Aria attributes as an alternative to PR jackmoore#821. Changes include: * Add `aria-hidden` attributes on the dialog box and navigational buttons. * Update the `aria-hidden` value to `true` or `false` at the appropriate times. * Add `aria-label` attributes to navigational buttons, using the colorbox default settings at page load time, and then update the value when a colorbox is loaded. * Add `aria-labelledby` and `aria-describedby` attributes to the div containing `role='dialog'`.
… live regions and ensure focus is on the first element in the dialog when it opens
… live regions and ensure focus is on the first element in the dialog when it opens
…esparkLabs/colorbox into 765-accessibility-compliance
…md/colorbox into 765-accessibility-compliance
|
Hope this gets pulled soon. But project looks dead :( |
|
@bramd, thanks for your additions on top of my #822 PR. I only happened to stumble across it by browsing the list of PRs so I'm leaving a comment here with a mention of my PR in order to link the two. Would you mind to add an issue description to summarize the additions you've done on top of mine? Thanks! |
This was referenced Feb 7, 2018
|
@jameswilson commented on Feb 7, 2018, 1:26 AM GMT+1:
Done. This description is based on a quick look at the commits I did, so I may have missed a few minor changes in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on earlier accessibility related workd by @jameswilson and adds the following: