Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a few issues #129

Merged
merged 5 commits into from
May 7, 2024
Merged

Fixes a few issues #129

merged 5 commits into from
May 7, 2024

Conversation

jaredpar
Copy link
Owner

@jaredpar jaredpar commented May 5, 2024

  1. The None host uses an in memory source generator
  2. Fixed a few places paths were not normalized

closes #126
closes #127

@jaredpar
Fixes a few issues
acfb7fb 
1. The None host uses an in memory source generator
2. Fixed a few places paths were not normalized

closes #126
closes #127
@jaredpar
fix
bd38edb
@jaredpar
more
f46a198
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (2fbe248) to head (e7f0c30).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   97.03%   96.35%   -0.68%     
==========================================
  Files          42       42              
  Lines        4075     4085      +10     
  Branches      404      401       -3     
==========================================
- Hits         3954     3936      -18     
- Misses         64       84      +20     
- Partials       57       65       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredpar jaredpar merged commit 926eb22 into main May 7, 2024
4 of 5 checks passed
@jaredpar jaredpar deleted the generated branch May 7, 2024 04:44
This was referenced Jun 24, 2024
Closed
Merged
jaredpar added a commit that referenced this pull request Jun 25, 2024
@jaredpar
Fix a couple of issues (#141)
9d78014 
This fixes the following issue:

- #129 missed a case where `None` was special cased in `CompilationData`. That meant it double added `SyntaxTree` items. 
- Potential source of non-determinism as we're iterating a dictionary without sorting keys first.

closes #139
closes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider having the None host use an actual generator Source text paths not being normalized
1 participant
@jaredpar