Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple of issues #141

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix a couple of issues #141

merged 2 commits into from
Jun 25, 2024

Conversation

jaredpar
Copy link
Owner

This fixes the following issue:

  • Fixes a few issues #129 missed a case where None was special cased in CompilationData. That meant it double added SyntaxTree items.
  • Potential source of non-determinism as we're iterating a dictionary without sorting keys first.

closes #139
closes #140

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (c310985) to head (7c22c7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   96.84%   96.82%   -0.03%     
==========================================
  Files          43       43              
  Lines        4221     4216       -5     
  Branches      425      424       -1     
==========================================
- Hits         4088     4082       -6     
  Misses         73       73              
- Partials       60       61       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredpar jaredpar merged commit 9d78014 into main Jun 25, 2024
4 of 5 checks passed
@jaredpar jaredpar deleted the fixes2 branch June 25, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant