-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test offenses #186
base: master
Are you sure you want to change the base?
Test offenses #186
Conversation
Bumps [pronto-rubocop](https://github.com/mmozuras/pronto-rubocop) from 0.11.1 to 0.11.2. - [Release notes](https://github.com/mmozuras/pronto-rubocop/releases) - [Commits](prontolabs/pronto-rubocop@v0.11.1...v0.11.2) --- updated-dependencies: - dependency-name: pronto-rubocop dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
@@ -171,7 +171,7 @@ def single_heading? | |||
end | |||
|
|||
def heading_price(heading) | |||
heading_ids.include?(heading.id) ? heading.price : -1 | |||
heading_ids.include?( heading.id) ? heading.price : -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/SpaceInsideParens: Space inside parentheses detected. (https://rubystyle.guide#spaces-braces)
heading_ids.include?( heading.id) ? heading.price : -1 | |
heading_ids.include?(heading.id) ? heading.price : -1 |
@@ -171,7 +171,7 @@ def single_heading? | |||
end | |||
|
|||
def heading_price(heading) | |||
heading_ids.include?(heading.id) ? heading.price : -1 | |||
heading_ids.include?( heading.id) ? heading.price : -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/SpaceAroundOperators: Operator ?
should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)
heading_ids.include?( heading.id) ? heading.price : -1 | |
heading_ids.include?( heading.id) ? heading.price : -1 |
@@ -171,7 +171,7 @@ def single_heading? | |||
end | |||
|
|||
def heading_price(heading) | |||
heading_ids.include?(heading.id) ? heading.price : -1 | |||
heading_ids.include?( heading.id) ? heading.price : -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/ExtraSpacing: Unnecessary spacing detected.
heading_ids.include?( heading.id) ? heading.price : -1 | |
heading_ids.include?( heading.id) ? heading.price : -1 |
@@ -187,7 +187,7 @@ def formatted_heading_price(heading) | |||
|
|||
def investments_orders | |||
case phase | |||
when "accepting", "reviewing", "finished" | |||
when 'accepting', 'reviewing', "finished" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://rubystyle.guide#consistent-string-literals)
when 'accepting', 'reviewing', "finished" | |
when "accepting", "reviewing", "finished" |
389e201
to
7c86945
Compare
No description provided.