Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test offenses #186

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Test offenses #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7c65c67
Use my repo
javierm Aug 22, 2022
bac0be6
Change position
javierm Aug 22, 2022
3f6f6b0
Put after card
javierm Aug 22, 2022
6fb2758
ID again
javierm Aug 22, 2022
d39dd33
Top
javierm Aug 22, 2022
2dc58be
Add renovate.json
renovate[bot] Aug 23, 2022
d29d622
Ignore dependencies
javierm Aug 23, 2022
d049d4b
Ignore more dependencies
javierm Aug 23, 2022
ffb161d
Ignore gemfile completely
javierm Aug 23, 2022
7bee063
Ignore github workflows
javierm Aug 24, 2022
8a3c6bd
Bump pronto-rubocop from 0.11.1 to 0.11.2
dependabot[bot] Aug 26, 2022
408490b
Test offenses
javierm Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/kanban.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,20 @@ env:
jobs:
assign_one_project:
name: Add new pull requests to the kanban
if: github.repository_owner == 'consul'
runs-on: ubuntu-latest
steps:
- name: Assign new pull requests to the reviewing column
uses: srggrs/assign-one-project-github-action@1.3.1
uses: andrenarchy/assign-one-project-github-action@master
if: github.event.pull_request.draft == false
with:
project: "https://github.com/orgs/consul/projects/1"
project: "https://github.com/users/javierm/projects/4"
column_name: "Reviewing"
position: "bottom"

- name: Assign new draft pull requests to the doing column
uses: srggrs/assign-one-project-github-action@1.3.1
uses: andrenarchy/assign-one-project-github-action@master
if: github.event.pull_request.draft == true
with:
project: "https://github.com/orgs/consul/projects/1"
project: "https://github.com/users/javierm/projects/4"
column_name: "Doing"
position: "top"
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ group :development do
gem "pronto", "~> 0.11.0", require: false
gem "pronto-erb_lint", "~> 0.1.5", require: false
gem "pronto-eslint", "~> 0.11.0", require: false
gem "pronto-rubocop", "~> 0.11.1", require: false
gem "pronto-rubocop", "~> 0.11.2", require: false
gem "pronto-scss", "~> 0.11.0", require: false
gem "rubocop", "~> 1.18.4", require: false
gem "rubocop-performance", "~> 1.11.4", require: false
Expand Down
52 changes: 28 additions & 24 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,27 +236,31 @@ GEM
railties (>= 5.0.0)
faker (2.22.0)
i18n (>= 1.8.11, < 2)
faraday (1.7.0)
faraday (1.10.2)
faraday-em_http (~> 1.0)
faraday-em_synchrony (~> 1.0)
faraday-excon (~> 1.1)
faraday-httpclient (~> 1.0.1)
faraday-httpclient (~> 1.0)
faraday-multipart (~> 1.0)
faraday-net_http (~> 1.0)
faraday-net_http_persistent (~> 1.1)
faraday-net_http_persistent (~> 1.0)
faraday-patron (~> 1.0)
faraday-rack (~> 1.0)
multipart-post (>= 1.2, < 3)
faraday-retry (~> 1.0)
ruby2_keywords (>= 0.0.4)
faraday-em_http (1.0.0)
faraday-em_synchrony (1.0.0)
faraday-excon (1.1.0)
faraday-http-cache (2.2.0)
faraday (>= 0.8)
faraday-httpclient (1.0.1)
faraday-multipart (1.0.4)
multipart-post (~> 2)
faraday-net_http (1.0.1)
faraday-net_http_persistent (1.2.0)
faraday-patron (1.0.0)
faraday-rack (1.0.0)
faraday-retry (1.0.3)
ffi (1.15.4)
file_validators (3.0.0)
activemodel (>= 3.2)
Expand All @@ -281,9 +285,9 @@ GEM
rainbow (>= 2.2.1)
rake (>= 10.0)
retriable (~> 3.0)
gitlab (4.17.0)
httparty (~> 0.18)
terminal-table (~> 1.5, >= 1.5.1)
gitlab (4.19.0)
httparty (~> 0.20)
terminal-table (>= 1.5.1)
globalid (1.0.0)
activesupport (>= 5.0)
globalize (6.2.1)
Expand All @@ -305,7 +309,7 @@ GEM
highline (2.0.3)
html_tokenizer (0.0.7)
htmlentities (4.3.4)
httparty (0.18.1)
httparty (0.20.0)
mime-types (~> 3.0)
multi_xml (>= 0.5.2)
httpi (2.5.0)
Expand Down Expand Up @@ -384,9 +388,9 @@ GEM
mixlib-config (>= 2.2.1, < 4)
mixlib-shellout
method_source (1.0.0)
mime-types (3.3.1)
mime-types (3.4.1)
mime-types-data (~> 3.2015)
mime-types-data (3.2021.0704)
mime-types-data (3.2022.0105)
mini_magick (4.11.0)
mini_mime (1.1.2)
mini_portile2 (2.8.0)
Expand All @@ -398,7 +402,7 @@ GEM
chef-utils
multi_json (1.15.0)
multi_xml (0.6.0)
multipart-post (2.1.1)
multipart-post (2.2.3)
net-scp (3.0.0)
net-ssh (>= 2.6.5, < 7.0.0)
net-ssh (6.1.0)
Expand All @@ -414,9 +418,9 @@ GEM
multi_json (~> 1.3)
multi_xml (~> 0.5)
rack (>= 1.2, < 3)
octokit (4.21.0)
faraday (>= 0.9)
sawyer (~> 0.8.0, >= 0.5.3)
octokit (4.25.1)
faraday (>= 1, < 3)
sawyer (~> 0.9)
omniauth (2.1.0)
hashie (>= 3.4.6)
rack (>= 2.2.3)
Expand All @@ -441,7 +445,7 @@ GEM
omniauth-oauth (~> 1.1)
rack
orm_adapter (0.5.0)
parallel (1.20.1)
parallel (1.22.1)
paranoia (2.6.0)
activerecord (>= 5.1, < 7.1)
parser (3.1.2.1)
Expand All @@ -464,7 +468,7 @@ GEM
pronto-eslint (0.11.0)
eslintrb (~> 2.0, >= 2.0.0)
pronto (~> 0.11.0)
pronto-rubocop (0.11.1)
pronto-rubocop (0.11.2)
pronto (~> 0.11.0)
rubocop (>= 0.63.1, < 2.0)
pronto-scss (0.11.0)
Expand Down Expand Up @@ -558,8 +562,8 @@ GEM
rubocop-ast (>= 1.8.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.9.1)
parser (>= 3.0.1.1)
rubocop-ast (1.21.0)
parser (>= 3.1.1.0)
rubocop-performance (1.11.4)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
Expand Down Expand Up @@ -603,9 +607,9 @@ GEM
nokogiri (>= 1.8.1)
nori (~> 2.4)
wasabi (~> 3.4)
sawyer (0.8.2)
sawyer (0.9.2)
addressable (>= 2.3.5)
faraday (> 0.8, < 2.0)
faraday (>= 0.17.3, < 3)
scss_lint (0.59.0)
sass (~> 3.5, >= 3.5.5)
selenium-webdriver (3.142.7)
Expand Down Expand Up @@ -642,8 +646,8 @@ GEM
sync (0.5.0)
term-ansicolor (1.7.1)
tins (~> 1.0)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
terminal-table (3.0.2)
unicode-display_width (>= 1.1.1, < 3)
terrapin (0.6.0)
climate_control (>= 0.0.3, < 1.0)
thor (1.2.1)
Expand All @@ -667,7 +671,7 @@ GEM
thread_safe (~> 0.1)
uglifier (4.2.0)
execjs (>= 0.3.0, < 3)
unicode-display_width (1.7.0)
unicode-display_width (2.2.0)
uniform_notifier (1.16.0)
uuidtools (2.1.5)
view_component (2.69.0)
Expand Down Expand Up @@ -771,7 +775,7 @@ DEPENDENCIES
pronto (~> 0.11.0)
pronto-erb_lint (~> 0.1.5)
pronto-eslint (~> 0.11.0)
pronto-rubocop (~> 0.11.1)
pronto-rubocop (~> 0.11.2)
pronto-scss (~> 0.11.0)
puma (~> 4.3.12)
rails (= 6.0.5.1)
Expand Down
4 changes: 2 additions & 2 deletions app/models/budget.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def single_heading?
end

def heading_price(heading)
heading_ids.include?(heading.id) ? heading.price : -1
heading_ids.include?( heading.id) ? heading.price : -1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/SpaceInsideParens: Space inside parentheses detected. (https://rubystyle.guide#spaces-braces)

Suggested change
heading_ids.include?( heading.id) ? heading.price : -1
heading_ids.include?(heading.id) ? heading.price : -1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/SpaceAroundOperators: Operator ? should be surrounded by a single space. (https://rubystyle.guide#spaces-operators)

Suggested change
heading_ids.include?( heading.id) ? heading.price : -1
heading_ids.include?( heading.id) ? heading.price : -1

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/ExtraSpacing: Unnecessary spacing detected.

Suggested change
heading_ids.include?( heading.id) ? heading.price : -1
heading_ids.include?( heading.id) ? heading.price : -1

end

def formatted_amount(amount)
Expand All @@ -187,7 +187,7 @@ def formatted_heading_price(heading)

def investments_orders
case phase
when "accepting", "reviewing", "finished"
when 'accepting', 'reviewing', "finished"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://rubystyle.guide#consistent-string-literals)

Suggested change
when 'accepting', 'reviewing', "finished"
when "accepting", "reviewing", "finished"

%w[random]
when "publishing_prices", "balloting", "reviewing_ballots"
hide_money? ? %w[random] : %w[random price]
Expand Down
7 changes: 7 additions & 0 deletions renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"config:base"
],
"ignorePaths": ["Gemfile", ".github/workflows/*"]
}