-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erb lint 0.3 test #190
base: master
Are you sure you want to change the base?
Erb lint 0.3 test #190
Conversation
ERB Lint 0.1 and later will add a default linter we're not interested in (RequireInputAutocomplete), at least for now. So, just like we do for Rubocop, we're disabling all linter and enabling them explicitly.
We also need to update pronto-erb_lint since the old version depended on erb_lint 0.0.x.
It's a default linter in erb_lint 0.3.0, and it's useful during development since I'm always unsure about the right way to add ERB comments.
@@ -3,7 +3,7 @@ | |||
<head> | |||
<meta charset="utf-8"> | |||
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> | |||
<%= wicked_pdf_stylesheet_link_tag "dashboard_poster" -%> | |||
<%= wicked_pdf_stylesheet_link_tag "dashboard_poster" =%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 1 space before %>
instead of 0 space.
@@ -12,6 +12,7 @@ | |||
|
|||
<%= raw setting["html.per_page_code_head"] %> | |||
</head> | |||
<% # TODO %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad ERB comment syntax. Should be <%# without a space between.
Leaving a space between ERB tags and the Ruby comment character can cause parser errors.
No description provided.