Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erb lint 0.3 test #190

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Erb lint 0.3 test #190

wants to merge 6 commits into from

Commits on Mar 17, 2023

  1. Use my repo

    @javierm
    javierm committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    695c4df View commit details
    Browse the repository at this point in the history

  2. Explicitly enable ERB linters 

    ERB Lint 0.1 and later will add a default linter we're not interested in
(RequireInputAutocomplete), at least for now.

So, just like we do for Rubocop, we're disabling all linter and enabling
them explicitly.
    @javierm
    javierm committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    338fafb View commit details
    Browse the repository at this point in the history

  3. Bump erb_lint from 0.0.37 to 0.3.0 

    We also need to update pronto-erb_lint since the old version depended on
erb_lint 0.0.x.
    @javierm
    javierm committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    e85a5be View commit details
    Browse the repository at this point in the history

  4. Enable CommentSyntax ERB Linter 

    It's a default linter in erb_lint 0.3.0, and it's useful during
development since I'm always unsure about the right way to add ERB
comments.
    @javierm
    javierm committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b332460 View commit details
    Browse the repository at this point in the history

  5. Add wrong comment

    @javierm
    javierm committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    b89ff3c View commit details
    Browse the repository at this point in the history

  6. Add wrong trim

    @javierm
    javierm committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    63ea6e5 View commit details
    Browse the repository at this point in the history