Refactor BrowseGridFragment hierarchy into a single class #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
the
refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Found 13 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Can this be merged into master, so i can directly use the cleaned-up classes. |
mueslimak3r
approved these changes
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BrowseGridFragment was the only one using these two
Before:
BrowseGridFragment extends StdGridFragment extends GridFragment extends FragmentAfter:
BrowseGridFragment FragmentMerging these classes removed a lot of boilerplate code and should make it easier to maintain it. Although the code is still quite messy. I've removed all the getter/setter functions that were only used in the class itself and merged some variables that were kept in both the grid and browsegrid fragments.
There are no behavior changes in this PR.
Changes
Issues