Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use view binding directly in BrowseGridFragment #1973

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Use view binding directly in BrowseGridFragment #1973

merged 1 commit into from
Aug 14, 2022

Conversation

nielsvanvelzen
Copy link
Member

Follow up for #1970

Changes

  • Use view binding directly in BrowseGridFragment
  • Inject UserRepository in class instead of in method
  • Fix JumplistPopup initialized with null parent view

Issues

@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Aug 14, 2022
@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Aug 14, 2022
@nielsvanvelzen nielsvanvelzen merged commit 2971e03 into jellyfin:master Aug 14, 2022
@nielsvanvelzen nielsvanvelzen deleted the browse-grid-viewbinding branch August 14, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero