Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge StdRowsFragment into HomeFragment #2074

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Merge StdRowsFragment into HomeFragment #2074

merged 1 commit into from
Sep 19, 2022

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Merge StdRowsFragment into HomeFragment
    • Remove a bunch of unused code from StdRowsFragment that was not used by HomeFragment

Issues

@nielsvanvelzen nielsvanvelzen added the refactor Improvements to code realiability, readability and quality label Sep 18, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 18, 2022
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/ui/home/HomeFragment.kt

//React to deletion
val dataRefreshService = get<DataRefreshService>(DataRefreshService::class.java)
if (activity != null && !requireActivity().isFinishing && currentRow != null && currentItem != null && currentItem!!.itemId != null && currentItem!!.itemId.equals(dataRefreshService.lastDeletedItemId)) {

Check warning

Code scanning / detekt

Complex conditions should be simplified and extracted into well-named methods if necessary.

This condition is too complex (6). Defined complexity threshold for conditions is set to '4'
app/src/main/java/org/jellyfin/androidtv/ui/home/HomeFragment.kt

//React to deletion
val dataRefreshService = get<DataRefreshService>(DataRefreshService::class.java)
if (activity != null && !requireActivity().isFinishing && currentRow != null && currentItem != null && currentItem!!.itemId != null && currentItem!!.itemId.equals(dataRefreshService.lastDeletedItemId)) {

Check warning

Code scanning / detekt

Line detected, which is longer than the defined maximum line length in the code style.

Line detected, which is longer than the defined maximum line length in the code style.
@nielsvanvelzen nielsvanvelzen mentioned this pull request Sep 18, 2022
Merged
@nielsvanvelzen nielsvanvelzen added this to the v0.15.0 milestone Sep 19, 2022
@nielsvanvelzen nielsvanvelzen merged commit c4ea2e9 into jellyfin:master Sep 19, 2022
@nielsvanvelzen nielsvanvelzen deleted the home-rows-fragment branch September 19, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
1 participant
@nielsvanvelzen