Use MutableObjectAdapter<Row> for rows #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
the
refactor
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| //React to deletion | ||
| val dataRefreshService = get<DataRefreshService>(DataRefreshService::class.java) | ||
| if (activity != null && !requireActivity().isFinishing && currentRow != null && currentItem != null && currentItem!!.itemId != null && currentItem!!.itemId.equals(dataRefreshService.lastDeletedItemId)) { |
Check warning
Code scanning / detekt
Complex conditions should be simplified and extracted into well-named methods if necessary.
|
|
||
| //React to deletion | ||
| val dataRefreshService = get<DataRefreshService>(DataRefreshService::class.java) | ||
| if (activity != null && !requireActivity().isFinishing && currentRow != null && currentItem != null && currentItem!!.itemId != null && currentItem!!.itemId.equals(dataRefreshService.lastDeletedItemId)) { |
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style.
There was a problem hiding this comment.
Found 96 potential problems in the proposed changes. Check the Files changed tab for more details.
nielsvanvelzen
force-pushed
the
mutable-object-adapter
branch
from
b9ed468
to
dbf75fb
Compare
There was a problem hiding this comment.
Found 96 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2074
Changes
Use our custom ObjectAdapter that is more flexible for all item rows, right now this shouldn't change the behavior.
Issues