Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle touches with UIControl #19

Merged
merged 7 commits into from
Nov 25, 2017
Merged

Handle touches with UIControl #19

merged 7 commits into from
Nov 25, 2017

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Nov 25, 2017 •
edited
Loading

  • handle touches with UIControl
  • refactoring

@jjochen jjochen changed the title Feature/refactoring handle touches with uicontrol Nov 25, 2017
@codecov
Copy link

codecov bot commented Nov 25, 2017 •
edited
Loading

Codecov Report

Merging #19 into develop will increase coverage by 15.17%.
The diff coverage is 97.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop      #19       +/-   ##
============================================
+ Coverage    79.71%   94.89%   +15.17%     
============================================
  Files            6        8        +2     
  Lines          567      548       -19     
============================================
+ Hits           452      520       +68     
+ Misses         115       28       -87
Impacted Files Coverage Δ
...atingActionButton/Classes/UIColor+Extensions.swift 100% <100%> (ø)
...oatingActionButton/Classes/JJCircleImageView.swift 94.54% <100%> (-0.84%) ⬇️
JJFloatingActionButton/Classes/JJActionItem.swift 91.66% <100%> (+45.37%) ⬆️
...gActionButton/Classes/JJFloatingActionButton.swift 97.12% <100%> (+18.34%) ⬆️
JJFloatingActionButton/Classes/JJCircleView.swift 89.28% <89.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917ec9a...38d5662. Read the comment docs.

@jjochen jjochen merged commit ad2927b into develop Nov 25, 2017
@jjochen jjochen deleted the feature/refactoring branch November 25, 2017 20:59
@jjochen jjochen added this to the 0.3.0 milestone Nov 26, 2017
jjochen added a commit that referenced this pull request Nov 26, 2017
@jjochen
Release 0.3.0 (#22)
b8b00cf 
* JJCircleImageViewTests

* add UI Tests

* ignore tests in codecov config

* cleanup tests

* improve ignored files

* add changelog

* recreated gif, absolute url in readme (#20)

* handle touches with uicontrol (#19)

* move circle view in a separate file, define default color

* handle touch related actions with UIControls

* improve test coverage

* fix tests

* cleanup

* travis: upgrade to xcode 9.1

* resolve warnings from pod lib lint

* update change log

* format

* add optional open button image (#21)

* add optional button image for open state

* add openButtonImage to README

* bump version

* update changelog

* update changelog
@jjochen jjochen changed the title handle touches with uicontrol Handle touches with uicontrol Dec 6, 2017
@jjochen jjochen changed the title Handle touches with uicontrol Handle touches with UIControl Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
updated
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jjochen