Add optional open button image #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjochen
changed the title
|
resolves #18 |
Codecov Report
@@ Coverage Diff @@
## develop #21 +/- ##
===========================================
+ Coverage 94.89% 94.94% +0.05%
===========================================
Files 8 8
Lines 548 554 +6
===========================================
+ Hits 520 526 +6
Misses 28 28
Continue to review full report at Codecov.
|
jjochen
added a commit
that referenced
this pull request
Nov 26, 2017
* JJCircleImageViewTests * add UI Tests * ignore tests in codecov config * cleanup tests * improve ignored files * add changelog * recreated gif, absolute url in readme (#20) * handle touches with uicontrol (#19) * move circle view in a separate file, define default color * handle touch related actions with UIControls * improve test coverage * fix tests * cleanup * travis: upgrade to xcode 9.1 * resolve warnings from pod lib lint * update change log * format * add optional open button image (#21) * add optional button image for open state * add openButtonImage to README * bump version * update changelog * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.