Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle item selection while menu is opening #227

Merged
merged 6 commits into from
Mar 1, 2020

Conversation

Claeysson
Copy link
Contributor

If a user taps an item before the menu is fully open the action is triggered but the menu doesn't close. This fixes the issue

Fixes close function when the menu is opening.
Fixes close function when the menu is opening.
@jjochen
Copy link
Owner

jjochen commented Feb 27, 2020

Awesome, I will update the tests.

@Claeysson
Copy link
Contributor Author

My solution isn’t perfect. The app will crash if the menu button is double tapped. Maybe you can look in to it.

Thanks!

@jjochen
Copy link
Owner

jjochen commented Feb 27, 2020

My solution isn’t perfect. The app will crash if the menu button is double tapped. Maybe you can look in to it.

Will do

@jjochen jjochen added this to the 2.2.0 milestone Feb 28, 2020
@jjochen jjochen added the added label Feb 28, 2020
@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #227 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          979       981    +2     
=========================================
+ Hits           979       981    +2     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6321d0c...b38373e. Read the comment docs.

@jjochen jjochen merged commit b38373e into jjochen:master Mar 1, 2020
@jjochen
Copy link
Owner

jjochen commented Mar 1, 2020

@Claeysson I pushed to the wrong (my) remote and closed the PR by mistake. Could you reopen it, please?

@jjochen jjochen added changed and removed added labels Mar 1, 2020
@jjochen jjochen changed the title Close when menu is opening Handle item taps while menu is opening Mar 1, 2020
@jjochen jjochen changed the title Handle item taps while menu is opening Handle item selection while menu is opening Mar 1, 2020
@jjochen jjochen added invalid and removed changed labels Mar 1, 2020
@jjochen jjochen removed this from the 2.2.0 milestone Mar 1, 2020
@jjochen
Copy link
Owner

jjochen commented Mar 1, 2020

I recreated this PR here.

@jjochen jjochen added duplicate and removed invalid labels Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants