-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle item selection while menu is opening #227
Conversation
Awesome, I will update the tests. |
My solution isn’t perfect. The app will crash if the menu button is double tapped. Maybe you can look in to it. Thanks! |
Will do |
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 979 981 +2
=========================================
+ Hits 979 981 +2 Continue to review full report at Codecov.
|
@Claeysson I pushed to the wrong (my) remote and closed the PR by mistake. Could you reopen it, please? |
I recreated this PR here. |
If a user taps an item before the menu is fully open the action is triggered but the menu doesn't close. This fixes the issue