Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow item selection during opening animation #233

Merged

Conversation

jjochen
Copy link
Owner

@jjochen jjochen commented Mar 1, 2020

No description provided.

@jjochen jjochen added the changed label Mar 1, 2020
@jjochen jjochen added this to the 2.2.0 milestone Mar 1, 2020
@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@16ba184). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #233   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     10           
  Lines             ?    981           
  Branches          ?      0           
=======================================
  Hits              ?    981           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
Sources/AnimationConfiguration.swift 100% <ø> (ø)
Sources/JJFloatingActionButton.swift 100% <100%> (ø)
Sources/UIColor+JJFloatingActionButton.swift 100% <100%> (ø)
Sources/JJActionItem.swift 100% <100%> (ø)
Sources/JJFloatingActionButton+Animation.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ba184...6d38a3e. Read the comment docs.

@jjochen jjochen marked this pull request as ready for review March 1, 2020 12:42
@jjochen jjochen merged commit 283032e into master Mar 1, 2020
@jjochen jjochen deleted the Claeysson/allow-item-selection-during-opening-animation branch March 1, 2020 12:47
@jjochen
Copy link
Owner Author

jjochen commented Mar 1, 2020

thanks @Claeysson!

zalexej pushed a commit to zalexej/JJFloatingActionButton that referenced this pull request Mar 6, 2020
* Close Fix

Fixes close function when the menu is opening.

* Close Fix

Fixes close function when the menu is opening.

* add relevant tests for taps during during opening animation

* prevent opening completion block when opening animation is interrupted

* add test for tap during during closing animation

* improve tests for actions

Co-authored-by: Martin Claesson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants