Skip to content

Commit

Permalink
Suppress error message in cmdDel, in thick plugin
Browse files Browse the repository at this point in the history
This fix suppress error message in thick plugin's shim, for
DEL command, to align with CNI spec.

Fix #1080
  • Loading branch information
s1061123 committed May 1, 2023
1 parent b9acfeb commit 9a67f96
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions pkg/server/api/shim.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ func CmdCheck(args *skel.CmdArgs) error {

// CmdDel implements the CNI spec DEL command handler
func CmdDel(args *skel.CmdArgs) error {
_, _, err := postRequest(args)
if err != nil {
return logging.Errorf("CmdDel (shim): %v", err)
}
_, _, _ = postRequest(args) // No error in DEL (as of CNI spec)
return nil
}

Expand Down

0 comments on commit 9a67f96

Please sign in to comment.