Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minify Content-Security-Policy #1014

Merged
merged 1 commit into from
Apr 1, 2019
Merged

minify Content-Security-Policy #1014

merged 1 commit into from
Apr 1, 2019

Conversation

alexlamsl
Copy link
Collaborator

fixes #947
closes #975

@alexlamsl
Copy link
Collaborator Author

@kangax sorry to bother again, but looks like after migration to travis-ci.com PR build jobs aren't working anymore (was working for .org, e.g. #1005)

I don't know which is easier/faster:

  • adding PR to webhook settings
  • removing Travis CI from Branch Protection requirements

But whichever way that allows me to merge any PRs would be greatly appreciated.

@alexlamsl
Copy link
Collaborator Author

@kangax friendly ping since I can't merge any PRs until this is resolved...

@alexlamsl alexlamsl closed this Apr 1, 2019
@alexlamsl alexlamsl reopened this Apr 1, 2019
@kangax
Copy link
Owner

kangax commented Apr 1, 2019

@alexlamsl sorry, I was away. Any ideas on how I can fix this?

@alexlamsl
Copy link
Collaborator Author

Sorry for nagging - so what happens is that PR-triggered jobs seem to work for travis-ci.org but not travis-ci.com, even though branch builds are working fine.

So while it could be some settings not enabled on the Travis CI side, but failing to narrow that down just remove Travis CI from the branch protection criteria for now.

@alexlamsl alexlamsl mentioned this pull request Apr 1, 2019
@kangax
Copy link
Owner

kangax commented Apr 1, 2019

@alexlamsl what about now?

@alexlamsl
Copy link
Collaborator Author

@kangax the merge button now works, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please minify Content Security Policy
3 participants