-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also minify CSPs (fixes #947) #975
Conversation
Please fix the test failures and rebase against upstream/master. |
I fixed the indentation issues with fa17d5c |
Looks good now. One thing I don't know though because I haven't dug deep into the codebase myself either, is if we need to lowercase tags, their names and/or their values before the comparisons. |
HTTP headers are case insensitive, plus the follow two MDN links listed So I'd say we need to do a lower case comparison here. Also, can we get a test case or two for this new feature? Just add a new section at the end of QUnit.test('minify Content-Security-Policy', function(assert) {
assert.equal(minify(...), ...);
...
}); |
So now there are also some test cases and a case insensitive check with e066084 |
Changes LGTM − now if I can just figure out how to get the Cursed Integration job to start for this PR... |
I hope everything is OK. (I didn't take a look into the whole codebase and don't know if this would be the right place to add it...)