Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: Include Pending Os in discovery #2188

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jan 17, 2022

What does this pull request do? Explain your changes. (required)
Make B discover Os that will be activated in the next round. It's related to the L2 migration so that the moved Os could be all of the sudden discovered.

Specific updates (required)
Update the round in the DB filter in db_discovery.go.

How did you test each of these updates (required)

Tested locally with geth.

  1. Before the change, B could not discover Os that were just registered.
  2. After the change, B could discover Os that were just registered.

Does this pull request close any open issues?

fix #2148

Checklist:

Copy link
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@darkdarkdragon darkdarkdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leszko leszko merged commit 9ab7a88 into livepeer:master Jan 20, 2022
@leszko leszko deleted the 2148-allow-discover-pending-o branch January 20, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Bs to discovery Os that are pending activation when using DB discovery
3 participants