Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accepting pending Os to accept traffic #2758

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Feb 15, 2023

What does this pull request do? Explain your changes. (required)

After the Arbitrum migration, we should move to the logic as before, meaning that only active Os can accept transcoding.

Related Discord discussion: https://discord.com/channels/423160867534929930/750796877762527262/1074970658544558092

This PR is an exact revert of these PRs: #2188 and #2146

Specific updates (required)

How did you test each of these updates (required)

Tested locally with local dev geth

Does this pull request close any open issues?

Checklist:

@leszko leszko requested a review from yondonfu February 15, 2023 16:43
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2758 (d6c76a3) into master (a8f3f4e) will decrease coverage by 0.03161%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2758         +/-   ##
===================================================
- Coverage   56.30182%   56.27021%   -0.03161%     
===================================================
  Files             88          88                 
  Lines          19177       19170          -7     
===================================================
- Hits           10797       10787         -10     
- Misses          7788        7791          +3     
  Partials         592         592                 
Impacted Files Coverage Δ
core/orchestrator.go 77.87115% <100.00000%> (-0.06181%) ⬇️
discovery/db_discovery.go 69.11765% <100.00000%> (-1.64047%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f467db...d6c76a3. Read the comment docs.

Impacted Files Coverage Δ
core/orchestrator.go 77.87115% <100.00000%> (-0.06181%) ⬇️
discovery/db_discovery.go 69.11765% <100.00000%> (-1.64047%) ⬇️

@leszko leszko merged commit 1bdb334 into master Feb 17, 2023
@leszko leszko deleted the rafal/revert-pending-os branch February 17, 2023 08:52
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants