Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.30 #2393

Merged
merged 11 commits into from
May 11, 2022
58 changes: 57 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,61 @@
# Changelog

## v0.5.30

*May 11 2022*

This release includes support for Netint transcoding hardware, dynamic timeouts for Orchestrator discovery, protection against rounds with a zero block hash and a number of small Orchestrator bug fixes.

### Breaking Changes 🚨🚨

None

### Features ⚒

#### General
- [#2348](https://github.com/livepeer/go-livepeer/pull/2348) Support Netint transcoding hardware (@cyberj0g)
- [#2289](https://github.com/livepeer/go-livepeer/pull/2289) Add timeouts to ETH client (@leszko)
- [#2282](https://github.com/livepeer/go-livepeer/pull/2282) Add checksums and gpg signature support with binary releases. (@hjpotter92)
- [#2344](https://github.com/livepeer/go-livepeer/pull/2344) Use T.TempDir to create temporary test directory (@Juneezee)
- [#2353](https://github.com/livepeer/go-livepeer/pull/2353) Codesign and notarize macOS binaries to be allowed to run without warnings on apple devices (@hjpotter92)
- [#2351](https://github.com/livepeer/go-livepeer/pull/2351) Refactor livepeer.go to enable running Livepeer node from the code (@leszko)
- [#2372](https://github.com/livepeer/go-livepeer/pull/2372) Upload test coverage reports to codecov (@hjpotter92)

#### Broadcaster
- [#2309](https://github.com/livepeer/go-livepeer/pull/2309) Add dynamic timeout for the orchestrator discovery (@leszko)
- [#2337](https://github.com/livepeer/go-livepeer/pull/2337) Fix dynamic discovery timeout to not retry sending requests, but wait for the same request to complete (@leszko)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we always have one bullet point per PR, but looking at it from the user perspective, the following 3 PRs provides one functionality: "Add dynamic timeout for the orchestrator discovery":

It's not strictly related to this release, but I think we can consider creating a changelog which is more user facing and less PR-driven.

Saying that, we can keep it as it is for this release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've kept the first one and removed the other two


#### Orchestrator
- [#2362](https://github.com/livepeer/go-livepeer/pull/2362) Backdate tickets by one round if the block hash for the current round is 0 (@leszko)

#### Transcoder

### Bug Fixes 🐞
- [#2355](https://github.com/livepeer/go-livepeer/pull/2355) Fix ZeroSegments error (@AlexKordic)

#### CLI
- [#2345](https://github.com/livepeer/go-livepeer/pull/2345) Improve user feedback when specifying numeric values for some wizard options (@kparkins)

#### General
- [#2299](https://github.com/livepeer/go-livepeer/pull/2299) Split devtool Orchestrator run scripts into versions with/without external transcoder and prevent Transcoder/Broadcaster run scripts from using same CLI port (@thomshutt)
- [#2346](https://github.com/livepeer/go-livepeer/pull/2346) Fix syntax errors in example JSON (@thomshutt)

#### Broadcaster
- [#2296](https://github.com/livepeer/go-livepeer/pull/2296) Increase orchestrator discovery timeout from `500ms` to `1` (@leszko)
- [#2291](https://github.com/livepeer/go-livepeer/pull/2291) Calling video comparison to improve the security strength (@oscar-davids)
- [#2326](https://github.com/livepeer/go-livepeer/pull/2326) Split Auth/Webhook functionality into its own file (@thomshutt)
- [#2357](https://github.com/livepeer/go-livepeer/pull/2357) Begin accepting auth header (from Mist) and have it override callback URL values (@thomshutt)
- [#2385](https://github.com/livepeer/go-livepeer/pull/2385) Change verification randomness variable meaning (@thomshutt)

#### Orchestrator
- [#2284](https://github.com/livepeer/go-livepeer/pull/2284) Fix issue with not redeeming tickets by Redeemer (@leszko)
- [#2352](https://github.com/livepeer/go-livepeer/pull/2352) Fix standalone orchestrator not crashing under UnrecoverableError (@leszko)
- [#2359](https://github.com/livepeer/go-livepeer/pull/2359) Fix redeeming tickets with zero block hash (@leszko)
- [#2390](https://github.com/livepeer/go-livepeer/pull/2390) Fix Orchestrator registration error when we receive an empty HTTP body (@leszko)

#### Transcoder
- N/A

## v0.5.29

*February 21 2022*
Expand Down Expand Up @@ -542,4 +598,4 @@ Thanks everyone that submitted bug reports and assisted in testing!
- [#1775](https://github.com/livepeer/go-livepeer/pull/1775) Fix transcoder load balancer race condition around session cleanup (@jailuthra)
- [#1784](https://github.com/livepeer/go-livepeer/pull/1784) Use auth token sessionID to index into sessions map in transcoder load balancer (@jailuthra)

[Full list of changes](https://github.com/livepeer/go-livepeer/compare/v0.5.14...v0.5.15)
[Full list of changes](https://github.com/livepeer/go-livepeer/compare/v0.5.14...v0.5.15)
22 changes: 0 additions & 22 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,21 @@
### Features ⚒

#### General
- \#2348 Support Netint transcoding hardware (@cyberj0g)
- \#2289 Add timeouts to ETH client (@leszko)
- \#2282 Add checksums and gpg signature support with binary releases. (@hjpotter92)
- \#2344 Use T.TempDir to create temporary test directory (@Juneezee)
- \#2353 Codesign and notarize macOS binaries to be allowed to run without warnings on apple devices (@hjpotter92)
- \#2351 Refactor livepeer.go to enable running Livepeer node from the code (@leszko)
- \#2372 Upload test coverage reports to codecov (@hjpotter92)

#### Broadcaster
- \#2309 Add dynamic timeout for the orchestrator discovery (@leszko)
- \#2337 Fix dynamic discovery timeout to not retry sending requests, but wait for the same request to complete (@leszko)

#### Orchestrator
- \#2362 Backdate tickets by one round if the block hash for the current round is 0 (@leszko)

#### Transcoder

### Bug Fixes 🐞
- \#2355 Fix ZeroSegments error (@AlexKordic)

#### CLI
- \#2345 Improve user feedback when specifying numeric values for some wizard options (@kparkins)

#### General
- \#2299 Split devtool Orchestrator run scripts into versions with/without external transcoder and prevent Transcoder/Broadcaster run scripts from using same CLI port (@thomshutt)
- \#2346 Fix syntax errors in example JSON

#### Broadcaster
- \#2296 Increase orchestrator discovery timeout from `500ms` to `1` (@leszko)
- \#2291 Calling video comparison to improve the security strength (@oscar-davids)
- \#2326 Split Auth/Webhook functionality into its own file (@thomshutt)
- \#2357 Begin accepting auth header (from Mist) and have it override callback URL values
- \#2385 Change verification randomness variable meaning

#### Orchestrator
- \#2284 Fix issue with not redeeming tickets by Redeemer (@leszko)
- \#2352 Fix standalone orchestrator not crashing under UnrecoverableError (@leszko)
- \#2359 Fix redeeming tickets with zero block hash (@leszko)

#### Transcoder
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.5.29
0.5.30
2 changes: 1 addition & 1 deletion cmd/livepeer_cli/wizard.go
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ func httpPostWithParamsHeaders(url string, val url.Values, headers map[string]st

defer resp.Body.Close()
result, err := ioutil.ReadAll(resp.Body)
if err != nil || string(result) == "" {
thomshutt marked this conversation as resolved.
Show resolved Hide resolved
if err != nil {
return "", false
}

Expand Down