Release v0.5.30 #2393
Merged
Release v0.5.30 #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszko
approved these changes
May 10, 2022
CHANGELOG.md
Outdated
Comment on lines
25
to
26
| - [#2309](https://github.com/livepeer/go-livepeer/pull/2309) Add dynamic timeout for the orchestrator discovery (@leszko) | ||
| - [#2337](https://github.com/livepeer/go-livepeer/pull/2337) Fix dynamic discovery timeout to not retry sending requests, but wait for the same request to complete (@leszko) |
There was a problem hiding this comment.
I know we always have one bullet point per PR, but looking at it from the user perspective, the following 3 PRs provides one functionality: "Add dynamic timeout for the orchestrator discovery":
- discovery: Add dynamic timeout for the orchestrator discovery #2309 => The actual PR introducing a feature
- Fix dynamic discovery timeout to not retry sending requests, but wait for the same request to complete #2337 => Fix for the PR above
- discovery: Increase orchestrator discovery timeout from 500ms to 1s #2296 => Attempt before the above was implemented
It's not strictly related to this release, but I think we can consider creating a changelog which is more user facing and less PR-driven.
Saying that, we can keep it as it is for this release.
There was a problem hiding this comment.
Good point, I've kept the first one and removed the other two
ad-astra-video
pushed a commit
to ad-astra-video/go-livepeer
that referenced
this pull request
May 25, 2022
Co-authored-by: Rafał Leszko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Version bump to v0.5.30.
Specific updates (required)
See commit history.
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass