fix(fonts): adds docs and tests for potentially missing language pack (…

…#9)
lob · May 10, 2019 · 27ba8d7 · 27ba8d7
1 parent 7014aa7
commit 27ba8d7
Show file tree

Hide file tree

Showing 4 changed files with 96 additions and 2 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -10,8 +10,14 @@ jobs:
       - run:
           name: Install system dependencies
           command: |
-            sudo apt-get update
-            sudo apt-get install -y --no-install-recommends g++-4.9 libpoppler-private-dev lcov
+            sudo sh -c 'echo "deb http://deb.debian.org/debian/ jessie main" > /etc/apt/sources.list'
+            sudo sh -c 'echo "deb-src http://deb.debian.org/debian/ jessie main" >> /etc/apt/sources.list'
+            sudo sh -c 'echo "deb http://security.debian.org/ jessie/updates main" >> /etc/apt/sources.list'
+            sudo sh -c 'echo "deb-src http://security.debian.org/ jessie/updates main" >> /etc/apt/sources.list'
+            sudo sh -c 'echo "deb http://archive.debian.org/debian jessie-backports main" >> /etc/apt/sources.list'
+            sudo sh -c 'echo "deb-src http://archive.debian.org/debian jessie-backports main" >> /etc/apt/sources.list'
+            sudo apt-get update -o Acquire::Check-Valid-Until=false -o Acquire::CompressionTypes::Order::=gz
+            sudo apt-get install -y --no-install-recommends g++-4.9 libpoppler-private-dev poppler-data lcov
 
       - run:
           name: Install Node dependencies

diff --git a/README.md b/README.md
@@ -20,6 +20,7 @@ To install Poppler on Ubuntu/Debian:
 ```
 apt-get install pkg-config
 apt-get install libpoppler-private-dev
+apt-get install poppler-data
 ```
 
 ## Usage

diff --git a/test/assets/language-pack-required.pdf b/test/assets/language-pack-required.pdf
diff --git a/test/pdffonts.test.js b/test/pdffonts.test.js
@@ -11,6 +11,7 @@ const NON_PDF_PATH           = Path.resolve(__dirname, 'assets/non-pdf.png');
 const NONEMBEDDED_FONTS_PATH = Path.resolve(__dirname, 'assets/nonembedded-fonts.pdf');
 const NONEXISTENT_PATH       = Path.resolve(__dirname, 'assets/nonexistent.pdf');
 const TYPE_3_FONT_PATH       = Path.resolve(__dirname, 'assets/type-3-font.pdf');
+const LANGUAGE_PACK_REQUIRED = Path.resolve(__dirname, 'assets/language-pack-required.pdf');
 
 describe('pdffonts', () => {
 
@@ -75,6 +76,92 @@ describe('pdffonts', () => {
       });
     });
 
+    it('handles language pack-required mappings', () => {
+      return PDFFonts.fonts(LANGUAGE_PACK_REQUIRED)
+      .then((fonts) => {
+        expect(fonts).to.eql([
+          {
+            name: 'DotumChe',
+            type: 'CID Type 0',
+            encoding: 'KSCms-UHC-H',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 41,
+              generation: 0
+            }
+          }, {
+            name: 'SimSun',
+            type: 'CID Type 0',
+            encoding: 'GBK-EUC-H',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 37,
+              generation: 0
+            }
+          }, {
+            name: 'MS-Gothic',
+            type: 'CID Type 0',
+            encoding: '90ms-RKSJ-H',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 44,
+              generation: 0
+            }
+          }, {
+            name: 'MingLiU',
+            type: 'CID Type 0',
+            encoding: 'ETen-B5-H',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 43,
+              generation: 0
+            }
+          }, {
+            name: 'Helvetica',
+            type: 'Type 1',
+            encoding: 'Custom',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 39,
+              generation: 0
+            }
+          }, {
+            name: 'Helvetica',
+            type: 'Type 1',
+            encoding: 'Custom',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 38,
+              generation: 0
+            }
+          }, {
+            name: 'Helvetica',
+            type: 'Type 1',
+            encoding: 'Custom',
+            embedded: false,
+            subset: false,
+            unicode: false,
+            object: {
+              number: 40,
+              generation: 0
+            }
+          }
+        ]);
+      });
+    });
+
     it('throws an error if a file name is not passed in', () => {
       return PDFFonts.fonts()
       .catch((err) => err)