fix(fonts): adds docs and tests for potentially missing language pack #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjl2
approved these changes
May 10, 2019
|
@sjl2 Apparently this project doesn't use caching for CircleCI. We may need to bust the cache in lob-api. |
marklee22
reviewed
May 10, 2019
| sudo sh -c 'echo "deb http://archive.debian.org/debian jessie-backports main" >> /etc/apt/sources.list' | ||
| sudo sh -c 'echo "deb-src http://archive.debian.org/debian jessie-backports main" >> /etc/apt/sources.list' | ||
| sudo apt-get update -o Acquire::Check-Valid-Until=false -o Acquire::CompressionTypes::Order::=gz | ||
| sudo apt-get install -y --no-install-recommends g++-4.9 libpoppler-private-dev poppler-data lcov |
There was a problem hiding this comment.
Do we need to also run these commands on our docker image?
There was a problem hiding this comment.
Did you mean on Lob API? Theres a PR for that here: https://github.com/lob/lob-api/pull/5270
There was a problem hiding this comment.
Oh, my bad. I thought this was a lob-api fix PR. Ignore my comment.
|
@marklee22 Yeah the blank PDF is on purpose. I took the actual customer PDF that was causing the issue and removed all content from it for privacy reasons. Whats interesting is that the PDF looks blank but it still contains empty text that uses these bad fonts. So...pretty messed up PDFs to begin with. |
marklee22
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
poppler-datato the required library docsWhy
Recently Quantum reached out with some letter IDs that contained non-standard un-embedded fonts. We ran the PDFs through Adobe preflight (see screenshot), and even
pdffontslocally and confirmed that there were non-standard un-embedded fonts.It turns out that these fonts required an additional poppler package
poppler-datato properly detect them usingpdffonts. Otherwise, those fonts would be ignored and a warning would be thrown:This isn't explicitly necessary on our dev laptops because the homebrew formula we use also installs
poppler-data.To be clear, the changes in this PR won't fix the bug in lob-api since the fix is dependent on a system-installed dependency, but these changes document this corner-case.