Tauri #753
Tauri #753
Conversation
* Use app_local_data_dir() for database * Move get_app_storage_dir() into config
I tried to upgrade `ts-rs` to v8, but the new export mechanism is extremely confusing, and `TS_RS_EXPORT_DIR` does not seem to be respected (types should be outputted in the TS codebase, not the rust codebase).
|
Generating TypeScript bindings is a burden. Those definitions are probably better defined once as part of the application API in museeks. Every integration then needs to implement the bridging code manually instead of bringing their own definitions. |
I would argue this is a setup issue and not a philosophical issue. Types generated from the backend is a very very useful feature, I just need to automate it, without slowing the devX too much. Edit: Typically, by running |
Only a single TypeScript API is needed and those definitions should be driven by the requirements and use cases of the app and rendering. If you want pluggable backends then backends need to adapt these definitions instead of bringing their own. I already have JSON representations and JSON schema mapping and started to utilize |
|
I think I don't fully understand what you mean. Can you detail how using JSON schemas would be an improvement and how the dev workflow would look like? |
* Prevent re-importing tracks already in the DB * Misc cleaning (comments, todos, etc)
* Fix 'build' CI, passing TypeScript * Attempt to actually build the binaries by GitHub actions
* Keep generated types in Git - This provides a working copy of the repo without having to generate the types manually. - Types should be manually updated when changing the definition of one of its corresponding Rust struct. - The CI will catch if any artifact is not correctly generated. * Update .prettierignore + re-run prettier * Clean generated types, replace action + create script for gen
Breaking change for the DB. This will place the DB content in the "Museeks" folder instead of "io.museeks.app". This is cleaner, more aligned with what other apps are doing, and will prevent macOS from thinking it's an app file (when it's a folder)
Fixes deadlocks on context menu
- Don't listen and emit the same event from the back-end AND front-end, each process should have different event names - The code removed was used in Electron but not anymore (it was useful for dock actions or tray, but they're gone)
|
Let's merge this. It's not ready, but it will show the project is alive :) |
yarn cargo test --manifest-path src-tauri/Cargo.toml yarn tauri devLet me keep track of what's working and what's yet to be fixed using the
tauribranch. Non-exhaustive. Hard bockers are marked with 🚫.file_drop_handlerprevent default behaviour on Windows tauri-apps/wry#904get_multiplenot returning docs in the right ordercover.jpg, etc__systemthemeUnhandled Promise Rejection: QuotaExceededError: The quota has been exceeded.on webkitScreenshots