Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new icons for files in .vscode folder #2335

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added new icons for files in .vscode folder #2335

wants to merge 4 commits into from
+198 −145

Conversation

okineadev
Copy link
Contributor

@okineadev okineadev commented May 21, 2024 •
edited
Loading

Added icons for the following files:

  • .vscode/settings.json
  • .vscode/extensions.json
  • .vscode/launch.json
  • .vscode/settings.json

PKief and others added 2 commits May 20, 2024 12:29
@PKief
feat: ⚙️ Refactor pattern code structure (material-extensions#2326)
94e9ce8 
* feat: ⚙️ Refactor pattern code structure

* Rename type

* feat: update barrels

* feat: update recommended extensions for development

* Add comment
@okineadev
Added new icons for files in .vscode folder
5dc4c3d
@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2024 •
edited
Loading

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

🏞️ Generated preview
Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief self-requested a review May 22, 2024 18:45
PKief
PKief reviewed May 22, 2024
View reviewed changes
Copy link
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a nice idea, but we should also add an icon for the other files, right?

image

@okineadev
Copy link
Contributor Author

I think it's a nice idea, but we should also add an icon for the other files, right?

image

I will think about it tomorrow

@github-actions GitHub Actions
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@okineadev
Copy link
Contributor Author

@PKief, I added icons for tasks.json and launch.json, check them out

@PKief PKief force-pushed the main branch 2 times, most recently from e748540 to b209d61 Compare May 23, 2024 11:57
@PKief PKief force-pushed the main branch 2 times, most recently from eeb4f0e to b2e0fe4 Compare June 12, 2024 20:23
@PKief PKief force-pushed the main branch 2 times, most recently from 2ff604a to b1ad1d2 Compare July 5, 2024 17:31
@okineadev
Copy link
Contributor Author

Any updates?

@mallowigi
Copy link

Why not target all the json files inside the vscode directory ?

@okineadev
Copy link
Contributor Author

Why not target all the json files inside the vscode directory ?

And what other files can there be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PKief PKief PKief left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okineadev @mallowigi @PKief