Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for money data type #249

Closed
10 tasks done
kgodey opened this issue Jun 14, 2021 · 1 comment
Closed
10 tasks done

Implementation for money data type #249

kgodey opened this issue Jun 14, 2021 · 1 comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review type: meta List of related issues. Not meant to be worked on directly.
Milestone

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 14, 2021

Problem

Users will want to store monetary data in columns. We should allow them to do so and implement this type appropriately in the backend.

Proposed solution

Postgres has a built-in MONEY type, but the currency used for it is locked to the lc_monetary setting of the Postgres installation (see docs). We need to support storing money in different currencies in different columns, so we will create a custom MATHESAR_MONEY type.

Tasks that need to completed

Moved to a later milestone:

Additional context

@kgodey kgodey added type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL work: database needs: unblocking Blocked by other work labels Jun 14, 2021
@kgodey kgodey added this to the 8. Initial Data Types milestone Jun 14, 2021
@kgodey kgodey added status: detail needed type: meta List of related issues. Not meant to be worked on directly. ready Ready for implementation and removed needs: unblocking Blocked by other work type: enhancement New feature or request status: detail needed labels Jul 15, 2021
@kgodey kgodey added work: product and removed work: backend Related to Python, Django, and simple SQL work: database labels Sep 13, 2021
@kgodey kgodey changed the title Backend/API implementation for money data type Implementation for money data type Sep 13, 2021
@kgodey kgodey added pr-status: revision A PR awaiting follow-up work from its author after review and removed ready Ready for implementation labels Mar 1, 2022
@pavish
Copy link
Member

pavish commented Mar 15, 2023

I'm going to close this meta issue since the one pending item: #419 is tracked separately.

@pavish pavish closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review type: meta List of related issues. Not meant to be worked on directly.
Projects
No open projects
Development

No branches or pull requests

3 participants