Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update design for money data type options #655

Closed
Tracked by #249
kgodey opened this issue Sep 13, 2021 · 3 comments
Closed
Tracked by #249

Update design for money data type options #655

kgodey opened this issue Sep 13, 2021 · 3 comments
Assignees
@ghislaineguerin
Labels
ready Ready for implementation type: enhancement New feature or request
Milestone
[07] Initial Data...

Comments

@kgodey
Copy link
Contributor

kgodey commented Sep 13, 2021

Problem

During implementation of the money type, we realized that decimal precision should be a display option for money, not a database option.

Proposed solution

The data type options for money should be updated to have decimal precision as a display setting, not a database setting.

Additional context
@kgodey kgodey added type: enhancement New feature or request work: design ready Ready for implementation labels Sep 13, 2021
@kgodey kgodey added this to the 08. Initial Data Types milestone Sep 13, 2021
This was referenced Sep 13, 2021
Closed
Closed
@ghislaineguerin
Copy link
Contributor

ghislaineguerin commented Sep 13, 2021 •
edited
Loading

@kgodey I have updated the prototype and added a note to the global data types document https://wiki.mathesar.org/en/design/specs/global-data-type-components

@kgodey
Copy link
Contributor Author

kgodey commented Sep 13, 2021

@ghislaineguerin I don't see a display tab here: https://www.figma.com/proto/Uaf1ntcldzK2U41Jhw6vS2/Mathesar-MVP?page-id=4260%3A37440&node-id=4270%3A40881&viewport=324%2C48%2C0.29&scaling=contain&starting-point-node-id=4270%3A40881&show-proto-sidebar=1, only a database tab.

This was referenced Sep 13, 2021
Closed
Closed
@ghislaineguerin
Copy link
Contributor

The prototype is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghislaineguerin ghislaineguerin

Labels
ready Ready for implementation type: enhancement New feature or request
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[07] Initial Data Types
Development

No branches or pull requests
2 participants
@kgodey @ghislaineguerin