-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support per-record currency types #656
Comments
Is this still something that we want? I'd like to close this issue. We could waiti to take up any work like this until we have a clearer use case for it or a user requesting it.
My understanding is that the backend does not support per-record currency types. Currency type is implemented as a display option, as far as I know. If I'm wrong, I'd like to understand this better. |
The backend does support this, there was a misunderstanding about the original product spec, and this was implemented before we switched to the current money type. We decided to leave the older implementation as-is in case we wanted to support multi-currency money types in the future. That being said, this was 2 years ago, and we're rearchitecting the backend now. I can't imagine the code is anything but a liability at this point. I'm fine with closing this, but I do think we should also delete the associated backend code so it's not a maintenance burden. Maybe track that in a separate issue? cc @mathemancer |
Ok, I'm closing this then. Thanks for weighing in, @kgodey. I'll leave it to @mathemancer to open that separate issue as needed. |
Problem
Due to a misunderstanding in requirements, we accidentally ended up implementing a custom money type that can have a different currency in each record. Since we already have the backend for this, we might as well use it.
Proposed solution
We need a design for using the multi-currency money type. It's similar to the existing money type with the following changes:
Additional context
MATHESAR_TYPES.MONEY
type #647The text was updated successfully, but these errors were encountered: