Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per-record currency types #656

Closed
kgodey opened this issue Sep 13, 2021 · 3 comments
Closed

Support per-record currency types #656

kgodey opened this issue Sep 13, 2021 · 3 comments
Labels
needs: ux design type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@kgodey
Copy link
Contributor

kgodey commented Sep 13, 2021

Problem

Due to a misunderstanding in requirements, we accidentally ended up implementing a custom money type that can have a different currency in each record. Since we already have the backend for this, we might as well use it.

Proposed solution

We need a design for using the multi-currency money type. It's similar to the existing money type with the following changes:

  • Users should be able to set and change the currency on a per-record basis. There should be a currency picker to allow them to select from existing currencies.
  • Users should be able to set the default currency for a column as a display option. We will pre-fill this currency for them to avoid repetitive data entry.
  • Users can set the decimal precision of a column as a display option, but cannot set it on a per-record basis.

Additional context

@kgodey kgodey added type: enhancement New feature or request work: design ready Ready for implementation labels Sep 13, 2021
@kgodey kgodey added this to the 15. 2021-11 Stability milestone Sep 13, 2021
@kgodey kgodey modified the milestones: 15. 2021-11 Stability, 2021-11 improvements Sep 28, 2021
@kgodey kgodey modified the milestones: [07.1] 2021-12 improvements, [10] UI Styling, [09] UI Styling, [11.2] 2022-05 improvements Dec 13, 2021
@kgodey kgodey modified the milestones: [08.1] 2022-05 improvements, Unprioritized Jun 1, 2022
@github-actions github-actions bot added the stale label Dec 19, 2022
@seancolsen seancolsen added needs: ux design work: frontend Related to frontend code in the mathesar_ui directory and removed stale ready Ready for implementation labels Dec 5, 2023
@mathesar-foundation mathesar-foundation deleted a comment from github-actions bot Dec 6, 2023
@seancolsen
Copy link
Contributor

seancolsen commented Dec 6, 2023

@kgodey

Users should be able to set and change the currency on a per-record basis

Is this still something that we want? I'd like to close this issue. We could waiti to take up any work like this until we have a clearer use case for it or a user requesting it.

we already have the backend for this

My understanding is that the backend does not support per-record currency types. Currency type is implemented as a display option, as far as I know. If I'm wrong, I'd like to understand this better.

@seancolsen seancolsen changed the title Design for multi-currency money type Support per-record currency types Dec 6, 2023
@kgodey
Copy link
Contributor Author

kgodey commented Dec 6, 2023

My understanding is that the backend does not support per-record currency types. Currency type is implemented as a display option, as far as I know. If I'm wrong, I'd like to understand this better.

The backend does support this, there was a misunderstanding about the original product spec, and this was implemented before we switched to the current money type. We decided to leave the older implementation as-is in case we wanted to support multi-currency money types in the future.

That being said, this was 2 years ago, and we're rearchitecting the backend now. I can't imagine the code is anything but a liability at this point. I'm fine with closing this, but I do think we should also delete the associated backend code so it's not a maintenance burden. Maybe track that in a separate issue? cc @mathemancer

@seancolsen
Copy link
Contributor

Ok, I'm closing this then. Thanks for weighing in, @kgodey. I'll leave it to @mathemancer to open that separate issue as needed.

@seancolsen seancolsen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: ux design type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

No branches or pull requests

2 participants