Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering options for the email type #410

Closed
Tracked by #245
kgodey opened this issue Jul 16, 2021 · 0 comments · Fixed by #1087
Closed
Tracked by #245

Implement filtering options for the email type #410

kgodey opened this issue Jul 16, 2021 · 0 comments · Fixed by #1087
Assignees
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jul 16, 2021

Problem

We need to ensure that records that include columns of the MATHESAR_EMAIL type support the following filters via API:

  • contains {x}
  • does not contain {x}
  • is {x}
  • is not {x}
  • is empty
  • is not empty
  • domain contains {x}
  • domain does not contain {x}
  • domain is {x}
  • domain is not {x}

The ones in bold are unique to the email type.

This involves:

  • Implementing the filters in the backend
  • Updating the /api/v0/databases/<id>/types/ endpoint to store available filters on this type
    • Filter information should include the number of parameters needing to be passed in (e.g. is needs 1 parameter, is empty needs 0)

Additional context

@kgodey kgodey added this to the 07. Initial Data Types milestone Jul 16, 2021
@kgodey kgodey added work: backend Related to Python, Django, and simple SQL work: database ready Ready for implementation type: enhancement New feature or request labels Jul 16, 2021
@kgodey kgodey assigned eito-fis and kgodey and unassigned eito-fis Aug 10, 2021
@kgodey kgodey assigned powellc and unassigned kgodey Aug 31, 2021
@kgodey kgodey assigned mathemancer and unassigned powellc Oct 5, 2021
@dmos62 dmos62 self-assigned this Dec 14, 2021
@dmos62 dmos62 mentioned this issue Dec 16, 2021
7 tasks
@dmos62 dmos62 mentioned this issue Feb 21, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: backend Related to Python, Django, and simple SQL
Projects
No open projects
5 participants