Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): add @runtime_checkable decorator for CustomTreeNode protocol class #56

Merged
merged 2 commits into from
May 23, 2023

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented May 23, 2023

Description

Describe your changes in detail.

Add @runtime_checkable decorator for CustomTreeNode protocol class.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Fix CI failure since typing-extensions 4.6.0 was released.

Refs:

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan added bug Something isn't working py Something related to the Python source code dependencies Pull requests that update a dependency file labels May 23, 2023
@XuehaiPan XuehaiPan self-assigned this May 23, 2023
@XuehaiPan XuehaiPan changed the title fix(typing): add @runtime_checkable decorator for CustomTreeNode protocal class fix(typing): add @runtime_checkable decorator for CustomTreeNode protocol class May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c0dc7c8) 100.00% compared to head (e298970) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #56   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          424       424           
=========================================
  Hits           424       424           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Benjamin-eecs Benjamin-eecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuehaiPan XuehaiPan merged commit 13ccd29 into metaopt:main May 23, 2023
@XuehaiPan XuehaiPan deleted the fix-runtime-protocal branch May 23, 2023 08:46
@XuehaiPan XuehaiPan added this to the 0.9.1 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file py Something related to the Python source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants