-
-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-38908: Fix issue when non runtime_protocol does not raise TypeError #26067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yurii, thanks for sending a PR to make sure there are no regressions for this long-standing issue!
Co-authored-by: Ken Jin <[email protected]>
@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it. |
Oh interesting! class P(Protocol):
x : int doesn't! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once again, thank you for fixing this!
Misc/NEWS.d/next/Library/2021-05-12-16-43-21.bpo-38908.nM2_rO.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Ken Jin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Does this need backporting?
@gvanrossum: Please replace |
Thanks @uriyyo for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
…ror (pythonGH-26067) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas <[email protected]>
GH-26073 is a backport of this pull request to the 3.10 branch. |
Sorry, @uriyyo and @gvanrossum, I could not cleanly backport this to |
I'm on it. It's clashing because the |
GH-26075 is a backport of this pull request to the 3.9 branch. |
…ror (GH-26067) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas <[email protected]>
…ypeError (GH-26067) (GH-26075) (cherry picked from commit c40486a) Co-authored-by: Yurii Karabas [email protected] Automerge-Triggered-By: GH:gvanrossum
… raise TypeError (pythonGH-26067) (pythonGH-26075)" This reverts commit 88136bb.
Backport of CPython PR 26067 (python/cpython#26067)
https://bugs.python.org/issue38908