Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067)" #26077

Merged
merged 1 commit into from
May 12, 2021
Merged

[3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise TypeError (GH-26067)" #26077

merged 1 commit into from
May 12, 2021

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 12, 2021 •
edited by miss-islington
Loading

Reverts #26075

https://bugs.python.org/issue38908

Automerge-Triggered-By: GH:gvanrossum

@Fidget-Spinner Fidget-Spinner mentioned this pull request May 12, 2021
Merged
gvanrossum
gvanrossum approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you're right, let's be safe.

(Is there a what's new entry for this in 3.10? If we're being picky here, it should be mentioned there.)

@Fidget-Spinner
Copy link
Member Author

Yeah, you're right, let's be safe.

(Is there a what's new entry for this in 3.10? If we're being picky here, it should be mentioned there.)

Thanks! And no there isn't. I'll work on it tomorrow.

@miss-islington
Copy link
Contributor

@Fidget-Spinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 9b90ce6 into python:3.9 May 12, 2021
@Fidget-Spinner Fidget-Spinner deleted the revert-26075-backport-c40486a32d branch May 13, 2021 09:04
@AlexWaygood AlexWaygood mentioned this pull request Apr 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fidget-Spinner @miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot