Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALL: H2 in Main Navigation appears in document before H1 #539

Closed
Tracked by #555
, #629
...
imcbride opened this issue Aug 30, 2023 · 1 comment · Fixed by #555 or #629
Closed
Tracked by #555
, #629
...

ALL: H2 in Main Navigation appears in document before H1 #539

imcbride opened this issue Aug 30, 2023 · 1 comment · Fixed by #555 or #629
Labels
accessibility site: all schools

Comments

@imcbride
Copy link
Member

https://my2.siteimprove.com/Inspector/7333/A11Y/Page?pageId=64768883914&impmd=ERAQQMIEOUHRRKBGATMU&decision=dismissed+falsePositive+none#/sia-r61/failed/ZWNDUktvRHo=;NjgxNGViNjc=

https://github.com/middlebury/midd-frontend/blob/master/src/templates/partials/school-header.twig#L34
poojagunturu96 added a commit that referenced this issue Oct 20, 2023
@poojagunturu96
twig: remove aria-labelledby attribute and h2 it is referencing as it…
b300bf7 
… causes accessbility issues when an h1 is present after the h2, replace at with aria-label instead. For #539.
@poojagunturu96 poojagunturu96 mentioned this issue Oct 31, 2023
Merged
5 tasks
@poojagunturu96 poojagunturu96 linked a pull request Nov 17, 2023 that will close this issue
Accessibility updates #555
Merged
5 tasks
@poojagunturu96
Copy link
Contributor

Issue still exists on several other pages as listed in this report: https://my2.siteimprove.com/Accessibility/7333/NextGen/Issue/1?ruleId=61&pageSegments=&issueKind=1&exceptTags=1,2&conformance=&siteTargetIssueKinds=1,2&wcagVersion=21&siteTarget.wcagVersion=21&siteTarget.conformanceLevels=0,1,3,4&siteTarget.issueKinds=1,2.

There are several instances of an <h2 class="sr-only"> tag being used for labelling elements in the frontend code which need to be reviewed: https://github.com/search?q=repo%3Amiddlebury%2Fmidd-frontend%20h2%20class%3D%22sr-only%22&type=code.

poojagunturu96 added a commit that referenced this issue Jul 9, 2024
@poojagunturu96
update navs to use aria-label attribute instead of aria-labelledby to…
98c7278 
… remove h2s causing accessibilty issues, for #539
@poojagunturu96 poojagunturu96 mentioned this issue Jul 9, 2024
Merged
5 tasks
@poojagunturu96 poojagunturu96 linked a pull request Aug 15, 2024 that will close this issue
Accessibility updates v3 #629
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility site: all schools
Projects
None yet
Milestone
No milestone
2 participants
@imcbride @poojagunturu96