Accessibility updates #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
poojagunturu96
commented
Oct 17, 2023
•
poojagunturu96
commented
- ALL: Check the accessibility of link elements used in the gallery component #447
- Table header text in table of links on profile detail appears twice in markup to make design work #542
- ALL: H2 in Main Navigation appears in document before H1 #539
- ALL: aria-labelledby is unsupported when used on the header element #540
- ALL: ARIA attribute aria-selected unsupported on td element #562
…accessbility. For #542.
… causes accessbility issues when an h1 is present after the h2, replace at with aria-label instead. For #539.
This was
linked to
issues
Nov 17, 2023
imcbride
reviewed
Dec 7, 2023
| <a href="/gallery-images#modal-{{ id }}" class="sr-only" target="_blank">View the gallery in a new window.</a> | ||
| <a class="gallery__link" data-lightbox-open="midd-lightbox-1" aria-label="Open gallery" aria-describedby="midd-gallery-1-label midd-gallery-1-count" role="button"> | ||
| <a | ||
| href="/" |
There was a problem hiding this comment.
On this, can we retain the unique URLs for viewing the page of the gallery images at /gallery-images#modal-{{ id }}? I worry that linking to the homepage isn't contextually relevant.
There was a problem hiding this comment.
Yes, I had reverted back to the old code which had href="/" but I meant for it to be the link to the gallery images page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.