Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer Upgrade UI #318

Merged
merged 102 commits into from
Aug 23, 2021
Merged

Layer Upgrade UI #318

merged 102 commits into from
Aug 23, 2021

Conversation

clemiller
Copy link
Contributor

@clemiller clemiller commented Jul 9, 2021

Implements the Layer Upgrade workflow in the sidebar to upgrade layers created in older versions of ATT&CK.

  • Displays technique changes that occurred between the two versions
  • Allows users to map annotations from the previous version to the current version
  • Techniques with tactics that do not map one-to-one between versions have a drag & drop interface
  • Each step can be filtered to show only techniques which have annotations
  • Provides links to attack.mitre.org for both versions of each technique

Resolves #181

…nce as subtechniques assigned to parent techniques
@clemiller clemiller changed the title WIP: Layer Upgrade UI Layer Upgrade UI Aug 10, 2021
Copy link
Contributor

@isaisabel isaisabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic improvement and I really only have minor comments at this point. There is really only one behavioral change, the rest is just documentation improvements.

nav-app/src/app/layer-upgrade/layer-upgrade.component.ts Outdated Show resolved Hide resolved
nav-app/src/app/viewmodels.service.ts Outdated Show resolved Hide resolved
nav-app/src/app/layer-upgrade/layer-upgrade.component.html Outdated Show resolved Hide resolved
nav-app/src/app/layer-upgrade/layer-upgrade.component.html Outdated Show resolved Hide resolved
nav-app/src/app/layer-upgrade/layer-upgrade.component.ts Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
USAGE.md Outdated Show resolved Hide resolved
USAGE.md Show resolved Hide resolved
Copy link
Contributor

@isaisabel isaisabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look good here, I have no other comments on the layer upgrade UI.

I have discovered one comparability issue with the current development branch: the "search & multiselect merge notification" added in #336 could appear alongside the layer upgrade sidebar if the first thing a user does when they open the v4.4 Navigator is upgrade a layer.

image

The merge notification popover should not be shown if the user is upgrading the layer. Adding an extra check to this statement to determine if the layer upgrade dialog is present should produce the correct behavior: https://github.com/mitre-attack/attack-navigator/blob/develop/nav-app/src/app/search-and-multiselect/search-popover-notification/search-popover-notification.component.ts#L79

With that compatibility issue resolved this PR is suitable to merge.

@isaisabel isaisabel merged commit 9509917 into develop Aug 23, 2021
@clemiller clemiller deleted the feature/#181-layer-upgrade-ui branch February 17, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants