-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer Upgrade UI #318
Layer Upgrade UI #318
Conversation
…s to have uninitialized paginators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic improvement and I really only have minor comments at this point. There is really only one behavioral change, the rest is just documentation improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes all look good here, I have no other comments on the layer upgrade UI.
I have discovered one comparability issue with the current development branch: the "search & multiselect merge notification" added in #336 could appear alongside the layer upgrade sidebar if the first thing a user does when they open the v4.4 Navigator is upgrade a layer.
The merge notification popover should not be shown if the user is upgrading the layer. Adding an extra check to this statement to determine if the layer upgrade dialog is present should produce the correct behavior: https://github.com/mitre-attack/attack-navigator/blob/develop/nav-app/src/app/search-and-multiselect/search-popover-notification/search-popover-notification.component.ts#L79
With that compatibility issue resolved this PR is suitable to merge.
Implements the Layer Upgrade workflow in the sidebar to upgrade layers created in older versions of ATT&CK.
Resolves #181