-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port kinematics_plugin_loader to ROS2 #107
Port kinematics_plugin_loader to ROS2 #107
Conversation
54efef9
to
5fe0795
Compare
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
06cfbca
to
449cff2
Compare
This PR depends on PR#104 |
.../kinematics_plugin_loader/include/moveit/kinematics_plugin_loader/kinematics_plugin_loader.h
Outdated
Show resolved
Hide resolved
.../kinematics_plugin_loader/include/moveit/kinematics_plugin_loader/kinematics_plugin_loader.h
Outdated
Show resolved
Hide resolved
.../kinematics_plugin_loader/include/moveit/kinematics_plugin_loader/kinematics_plugin_loader.h
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
std::string ksolver_param_name; | ||
bool found = nh.searchParam(base_param_name + "/kinematics_solver", ksolver_param_name); | ||
if (!found || !nh.hasParam(ksolver_param_name)) | ||
std::string ksolver_param_name = base_param_name + "/kinematics_solver"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole part seems overly complicated to me (it already was in the original implementation). But it's probably not the point for premature optimization here. Could you add a TODO: revise parameter lookup
here so we can track what parameters we need to test/improve in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the yaml you linked doesn't belong to the cpp file. What they did is use dynamic_reconfigure to generate the parameters: https://github.com/ros-planning/navigation2/blob/6bfa8c48ea0291fff540eb7aead6e5e511130bd7/nav2_costmap_2d/cfg/ObstaclePlugin.cfg. Normal parameters use forward slashes as namespace separators, at least I didn't find anything that supports something else: https://design.ros2.org/articles/ros_parameters.html https://design.ros2.org/articles/topic_and_service_names.html.
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Show resolved
Hide resolved
.../kinematics_plugin_loader/include/moveit/kinematics_plugin_loader/kinematics_plugin_loader.h
Show resolved
Hide resolved
.../kinematics_plugin_loader/include/moveit/kinematics_plugin_loader/kinematics_plugin_loader.h
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! ;)
c0dbc56
to
7dd5db7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some minor changes, then lgtm
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
moveit_ros/planning/kinematics_plugin_loader/src/kinematics_plugin_loader.cpp
Outdated
Show resolved
Hide resolved
- Update CMakeLists.txt - Update parameter resolution - Update logger
7dd5db7
to
3e4e9e4
Compare
Description
This is a continuation of PR#74
I did the same as in this PR#104 for applying the changes